Issue 166970043: code review 166970043: A+C: Gabriel Aszalos (Individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166970043: code review 166970043: A+C: Gabriel Aszalos (Individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews

Visibility:
Public.

Description

A+C: Gabriel Aszalos (Individual CLA)

Patch Set 1 #

Patch Set 2 : diff -r 9340f9f6dfc9120543617696123f75a3d49a69dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9340f9f6dfc9120543617696123f75a3d49a69dd https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	CONTRIBUTORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2014-10-31 13:27:26 UTC) #1

bradfitz

11 years, 8 months ago (2014-10-31 17:16:30 UTC) #3

Whoops. I even LGTMed the other one.  These are all blurring together.
 On Oct 31, 2014 1:43 PM, <gobot@golang.org> wrote:

> R=close (assigned by iant@golang.org)
>
> https://codereview.appspot.com/166970043/
>

Expand All Messages | Collapse All Messages