Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/pinot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: apache/pinot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr_18172
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 6 files changed
  • 2 contributors

Commits on May 12, 2026

  1. Added initial code for multi-cluster broker routing debug API

    @shauryachats
    shauryachats committed May 12, 2026
    Configuration menu
    Copy the full SHA
    4c93076 View commit details
    Browse the repository at this point in the history

  2. Added improvements

    @shauryachats
    shauryachats committed May 12, 2026
    Configuration menu
    Copy the full SHA
    8754bf2 View commit details
    Browse the repository at this point in the history

  3. Add SQL-based multi-cluster routing table debug endpoint and reduce diff 

    - Add `useMultiClusterRouting` query param to `/debug/routingTable/sql` and
  `/debug/routingTableWithOptionalSegments/sql`: when true, extracts the
  logical table name from the compiled SQL, looks up its physical table config,
  and returns per-physical-table routing via the multi-cluster routing manager
- Change SQL endpoint return type to `Map<String, Map<ServerInstance, List<String>>>`
  for consistency with the table-name endpoints (single-entry map for non-multi-cluster case)
- Extract `collectRoutingTables` helper to eliminate the if/else duplication in
  both table-name endpoints; rename private helper to `lookupLocalRoutingTable`
  to avoid shadowing the public JAX-RS endpoint method name
- Add class-level Javadoc to PinotBrokerDebugTest; fix pre-existing
  `assertTrue(x != null)` → `assertNotNull(x)`
- Add unit tests: `testSqlEndpointNonMultiClusterWrapsResultInMap` and
  `testSqlMultiClusterRoutingSucceedsForLogicalTable`
- Add integration test `testMultiClusterRoutingTableDebugEndpoint` and
  `testMultiClusterSqlRoutingTableDebugEndpoint` to MultiClusterIntegrationTest

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
    @shauryachats @claude
    shauryachats and claude committed May 12, 2026
    Configuration menu
    Copy the full SHA
    1b3cdbb View commit details
    Browse the repository at this point in the history
Loading