Skip to content

Support batchCreate.#2947

Merged
yuchenshi merged 4 commits into
masterfrom
ys/auth-emu-batchCreate
Dec 17, 2020
Merged

Support batchCreate.#2947
yuchenshi merged 4 commits into
masterfrom
ys/auth-emu-batchCreate

Conversation

@yuchenshi

Copy link
Copy Markdown
Member

Description

This adds support for batchCreate, with a few corner cases intentionally omitted for sanity. One step closer to import/export!

Scenarios Tested

Comprehensive spec test added.

Sample Commands

@google-cla google-cla Bot added the cla: yes Manual indication that this has passed CLA. label Dec 17, 2020
Comment thread src/emulator/auth/operations.ts Outdated
Comment thread src/emulator/auth/operations.ts Outdated

@samtstern samtstern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you resolve your own TODOs

@yuchenshi yuchenshi merged commit b24b972 into master Dec 17, 2020
@yuchenshi yuchenshi deleted the ys/auth-emu-batchCreate branch December 17, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants