fix(storage): add universe domain to defaultSignBytesFunc#11521
Merged
Conversation
tritone
approved these changes
Jan 29, 2025
tritone
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Is this something we can test the roundtrip of with our signed URL tests?
Contributor
Author
Which signed URL tests? I was thinking of adding it to the universe domain integration tests once those can actually run. |
Contributor
That's also fine. |
quartzmo
approved these changes
Feb 4, 2025
This was referenced Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.