feat: add Vector Store#14
Merged
Merged
Conversation
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
kurtisvg
requested changes
Feb 10, 2024
Comment on lines
+90
to
+91
| if self.overwrite_existing: | ||
| await self.engine._aexecute(f"TRUNCATE TABLE {self.table_name}") |
Collaborator
There was a problem hiding this comment.
nit: I'm not sure I like this here...
Collaborator
Author
There was a problem hiding this comment.
Should we remove this feature altogether?
Collaborator
There was a problem hiding this comment.
Probably? I'm squeamish of the idea that TRUNCATE will destroy the data before the verification checks are done. But maybe it's best to just leave it out to prevent a footgun?
Collaborator
Author
There was a problem hiding this comment.
I removed this for now
kurtisvg
approved these changes
Feb 12, 2024
d522a39 to
2e1c55d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕