fix: Correct the field mask when adding labels to an instance that had none previously#114
Merged
Merged
Conversation
…d none previously
Contributor
|
I think this needs to be regenerated, similar to googleapis/google-cloud-ruby#26510 |
aandreassa
approved these changes
Aug 17, 2024
Contributor
|
LGTM. Just some other error on the build now. Something like: |
Contributor
Author
Yeah that's been there for a while on that job. We may need help from the spanner team, as I'm not sure what that job is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf 4.x had a breaking change that affected how proto messages are converted to hashes. This affected the field mask computation when setting instance attributes—in particular, when using protobuf 4.x, it was no longer possible to set labels on an instance that had none previously because the field mask was omitting the labels field. This fix updates the field mask computation to be immune to the change.