Skip to content

feat: Support setting the universe domain#144

Merged
dazuma merged 1 commit into
googleapis:mainfrom
dazuma:pr/universe
Feb 24, 2025
Merged

feat: Support setting the universe domain#144
dazuma merged 1 commit into
googleapis:mainfrom
dazuma:pr/universe

Conversation

@dazuma

@dazuma dazuma commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Spanner unfortunately needed a bit of a hack for proper universe_domain behavior. Normally, we just pass the universe domain down into the gapic-common layer and it will generate the correct endpoint host name. However, Spanner uses a prebuilt gRPC channel as a credential because of how it configures gRPC, which means we need to know the endpoint up front in order to construct that channel. Thus, we are currently copying from gapic-common (and settings from the GAPIC) to resolve the universe domain, and thus the endpoint. Later we will need to refactor things a bit to expose this logic either in the gapic-common layer or in the generated GAPIC, so the Spanner handwritten client can just call it directly.

@dazuma dazuma requested review from a team February 19, 2025 23:08
@dazuma dazuma marked this pull request as draft February 19, 2025 23:43
@dazuma dazuma force-pushed the pr/universe branch 5 times, most recently from a5191fc to 16f13a3 Compare February 20, 2025 00:28
@dazuma dazuma marked this pull request as ready for review February 20, 2025 00:28
@dazuma dazuma added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2025
@dazuma dazuma added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2025
@dazuma dazuma merged commit 7d26d0a into googleapis:main Feb 24, 2025
@dazuma dazuma deleted the pr/universe branch February 25, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants