feat: Support setting the universe domain#144
Merged
Conversation
a5191fc to
16f13a3
Compare
aandreassa
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanner unfortunately needed a bit of a hack for proper universe_domain behavior. Normally, we just pass the universe domain down into the gapic-common layer and it will generate the correct endpoint host name. However, Spanner uses a prebuilt gRPC channel as a credential because of how it configures gRPC, which means we need to know the endpoint up front in order to construct that channel. Thus, we are currently copying from gapic-common (and settings from the GAPIC) to resolve the universe domain, and thus the endpoint. Later we will need to refactor things a bit to expose this logic either in the gapic-common layer or in the generated GAPIC, so the Spanner handwritten client can just call it directly.