fix: Removed node-notifier unmaintained dependency#3689
Merged
Conversation
Member
Author
|
@willdurand @Rob--W CircleCI has a warning saying that github webhooks are currently experiencing an outage, let's wait a bit to see if the CI jobs gets run automatically after that github webhooks issue is resolved, and to eventually look into forcing the CI job to run if that isn't the case, before proceeding to review and eventually merge this PR. |
841c34d to
4d01c9b
Compare
4d01c9b to
566288c
Compare
Member
Author
|
I have rebased this patch to get past a CI job failure on the audit-deps step and then fixed a prettier linting error. This is now ready for a review pass. |
Rob--W
approved these changes
Apr 23, 2026
…t.extension-runners.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-notifier doesn't seem to be actively maintained, last update pushed on npm is from 4 years ago.
Given that we agreed to remove it from the web-ext dependencies, the use case in develop mode isn't really something we depend on and the use related to
web-ext runis more of a nice to have (the errors are still going to be reported in the console as it already was).This pull request is removing the dependencies and adjusting the implementation and test coverage accordingly.