chore(audit): add npm audit exception for uuid transitive dependency#3692
Merged
Conversation
Member
Author
|
@willdurand I'm going to merge this right now, so that I can rebase a few pull requests that have hit a CI job failure due on the audit-deps due to this. As mentioned in the description once we have merged #3689 it should also be easier to remove this exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is adding uuid advisory to the nsprc exception list as a short term workaround to fix CI jobs failures due to it.
After #3689 is signed off and merged then
uuidwould not be used by any of the dependencies included in the released package and without the node-notifier unmaintained dependency it should also be easier to remove this npm audit exception.