feat: add manual wrapper for v1beta2 read client#117
Conversation
|
Kokoro failure: I think there's a manual |
|
Re: @plamut Was this just for backwards compatibility? I imagine I could use the protobuf/proto-plus well-known type logic here instead. |
|
@tswast Since I was not that familiar with this library and short on time, I think I included these generated types like that to avoid import errors and unblock the microgenerator transition. I didn't explore if there exist dedicated synth settings for the |
|
This is ready for review. I used some parameterized test fixtures to keep from duplicating code in the system tests. Next, I'll start looking more closely at what needs to be done for the write client. |
We got a bit lucky in that the reader module doesn't create any proto objects, so it could be reused without modification from the "v1" endpoint. Maybe we should be defining these in a shared module that doesn't include the version information, though?
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: