Skip to content

feat: Implement transforms to/from Cloud Pub/Sub Messages#20

Merged
dpcollins-google merged 6 commits into
masterfrom
message_transforms
Sep 22, 2020
Merged

feat: Implement transforms to/from Cloud Pub/Sub Messages#20
dpcollins-google merged 6 commits into
masterfrom
message_transforms

Conversation

@hannahrogers-google

@hannahrogers-google hannahrogers-google commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Diffbased on #19

@hannahrogers-google hannahrogers-google requested a review from a team September 21, 2020 21:03
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2020
@dpcollins-google dpcollins-google changed the title Message transforms feat: Implement transforms to/from Cloud Pub/Sub Messages Sep 21, 2020
@dpcollins-google

Copy link
Copy Markdown
Contributor

Hannah had to open this for me since my github didn't want to create a new PR.

Comment thread google/cloud/pubsublite/internal/b64_utils.py Outdated
Comment thread tests/unit/pubsublite/cloudpubsub/message_transforms_test.py
The following code returns 18005 seconds as the time is timezone adjusted: PubSubMessage(event_time=Timestamp(seconds=5).ToDatetime())
Comment thread google/cloud/pubsublite/publish_metadata.py
Comment thread google/cloud/pubsublite/internal/b64_utils.py Outdated
Comment thread tests/unit/pubsublite/cloudpubsub/message_transforms_test.py Outdated
Comment thread google/cloud/pubsublite/cloudpubsub/message_transforms.py Outdated
@dpcollins-google dpcollins-google merged commit 903070d into master Sep 22, 2020
@anguillanneuf anguillanneuf deleted the message_transforms branch March 25, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants