Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 10321043: code review 10321043: runtime: move stack segment cache from M to P

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by dvyukov
Modified:
12 years, 4 months ago
CC:
iant, khr, rsc
Visibility:
Public.

Description

runtime: move stack segment cache from M to P It seems that the cache does not go away completely in 1.3, so I think it's worth it to move the cache from M to P as other caches. Large Go programs (especially the ones that use swig/cgo) can have hundreds of threads, currently max cache size is 256K, so it can save some dozens of MBs.

Patch Set 1 #

Patch Set 2 : diff -r a40ef06e2106 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 6e163a22bea3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 6e163a22bea3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 6e163a22bea3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 6e163a22bea3 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -37 lines) Patch
M src/pkg/runtime/mgc0.c View 1 2 3 4 chunks +11 lines, -10 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M src/pkg/runtime/stack.c View 1 2 3 4 6 chunks +35 lines, -23 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years, 4 months ago (2014-02-25 13:54:49 UTC) #1
gobot
R=khr@golang.org (assigned by r@golang.org)
12 years, 4 months ago (2014-02-27 16:51:17 UTC) #2
dvyukov
This can crash, because exitsyscall splits stack w/o P. It would be nice to eventually ...
12 years, 4 months ago (2014-02-27 17:08:20 UTC) #3
bradfitz
File a bug? On Thu, Feb 27, 2014 at 9:08 AM, <dvyukov@google.com> wrote: > This ...
12 years, 4 months ago (2014-02-27 17:13:32 UTC) #4
dvyukov
12 years, 4 months ago (2014-02-27 17:18:24 UTC) #5
https://code.google.com/p/go/issues/detail?id=7424

On Thu, Feb 27, 2014 at 9:13 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> File a bug?
>
>
>
> On Thu, Feb 27, 2014 at 9:08 AM, <dvyukov@google.com> wrote:
>>
>> This can crash, because exitsyscall splits stack w/o P. It would be nice
>> to eventually make it not split stack "outside of world" (w/o P). But
>> let' not rush.
>> R=close
>>
>>
>> https://codereview.appspot.com/10321043/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b