code review 107520043: vfs: replace symlinks with what they’re pointing to

vfs: replace symlinks with what they’re pointing to

This is necessary on Debian, where GOROOT is /usr/lib/go/, which
contains {doc,src,test} symlinks. We’ve been carrying this patch for
multiple years, so I’d like to finally get it upstream :).

[mstplbrg, 2014-07-04 22:29:14]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools/

[gobot, 2014-07-16 11:12:15]

R=adg@golang.org (assigned by dave@cheney.net)

[bradfitz, 2014-07-23 18:33:47]

Where is it documented that Readdir must return non-symlinks?  I see nothing in
os, net/http, or this vfs package that says that.

I think this might be fixing the problem at the wrong spot.

There are also no tests.

Let's start by discussing the actual problem. A bug might be the best place for
that.

[mstplbrg, 2014-07-24 06:21:57]

On 2014/07/23 18:33:47, bradfitz wrote:
> Where is it documented that Readdir must return non-symlinks?  I see nothing
in
> os, net/http, or this vfs package that says that.
> 
> I think this might be fixing the problem at the wrong spot.
> 
> There are also no tests.
> 
> Let's start by discussing the actual problem. A bug might be the best place
for
> that.

Actually, now that you mention it, there already was a bug:
https://code.google.com/p/go/issues/detail?id=1540 — any chance to reconsider
the resolution of that bug? Otherwise, nevermind and we’ll just carry this patch
in Debian forever :(.

[gobot, 2014-12-19 05:09:50]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/107520043 is best) in the description in your
new CL.

Thanks very much.