Issue 11768043: Correctly implement get-proof-by-hash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11768043: Correctly implement get-proof-by-hash

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Ben Laurie (Google)

Modified:
12 years, 11 months ago

Reviewers:
Al Cutter

Visibility:
Public.

More Reviews

Patch Set 2 : Respond to comments #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -11 lines)			Patch
M	src/log/log_lookup.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/log/log_lookup.cc	View		3 chunks	+24 lines, -1 line	0 comments	Download
M	src/proto/ct.proto	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	src/server/ct-rfc-server.cc	View	1	3 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Al Cutter

https://codereview.appspot.com/11768043/diff/1/src/log/log_lookup.cc File src/log/log_lookup.cc (right): https://codereview.appspot.com/11768043/diff/1/src/log/log_lookup.cc#newcode128 src/log/log_lookup.cc:128: for (size_t i = 0; i < audit_path.size(); ++i) ...

12 years, 11 months ago (2013-07-24 16:18:50 UTC) #2

Ben Laurie (Google)

12 years, 11 months ago (2013-07-25 13:27:45 UTC) #4

https://codereview.appspot.com/11768043/diff/1/src/log/log_lookup.cc
File src/log/log_lookup.cc (right):

https://codereview.appspot.com/11768043/diff/1/src/log/log_lookup.cc#newcode128
src/log/log_lookup.cc:128: for (size_t i = 0; i < audit_path.size(); ++i)
On 2013/07/24 16:18:50, Al Cutter wrote:
> for (const string& node : audit_path) ?

C++11 not allowed yet :-)

https://codereview.appspot.com/11768043/diff/1/src/server/ct-rfc-server.cc
File src/server/ct-rfc-server.cc (right):

https://codereview.appspot.com/11768043/diff/1/src/server/ct-rfc-server.cc#ne...
src/server/ct-rfc-server.cc:352: size_t tree_size =
atoi(qmap["tree_size"].c_str());
On 2013/07/24 16:18:50, Al Cutter wrote:
> check tree_size is valid here ?

It is checked further down, though perhaps not super informatively - if its
value is bogus, the resulting path is empty.

Fixed.

https://codereview.appspot.com/11768043/diff/1/src/server/ct-rfc-server.cc#ne...
src/server/ct-rfc-server.cc:355: // FIXME(benl): this is incorrect - it should
find the path to the
On 2013/07/24 16:18:50, Al Cutter wrote:
> Ding the comment :)

Done.

Expand All Messages | Collapse All Messages