code review 13427044: crypto/x509: allow ECDSA public keys to be marshaled.

crypto/x509: allow ECDSA public keys to be marshaled.

The public key serialization from CreateCertificate is factored out to be
used in MarshalPKIXPublicKey.
Testcode with one P224 ECDSA keypair has been added.

[nick1, 2013-09-09 22:50:51]

Hello golang-dev@googlegroups.com (cc: agl@chromium.org, agl@golang.org,
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[agl1, 2013-09-10 16:27:23]

https://codereview.appspot.com/13427044/diff/5001/src/pkg/crypto/x509/x509.go
File src/pkg/crypto/x509/x509.go (right):

https://codereview.appspot.com/13427044/diff/5001/src/pkg/crypto/x509/x509.go...
src/pkg/crypto/x509/x509.go:48: func marshalPublicKey(pub interface{})
(publicKeyBytes []byte, err error) {
extractPublicKeyAlgorithm should be merged into this function and this function
can return ([]byte, pkix.AlgorithmIdentifier, error). This saves an additional
type switch and both callers are just calling one after the other already.

[nick1, 2013-09-10 17:39:58]

Hello golang-dev@googlegroups.com, agl@golang.org (cc: agl@chromium.org,
golang-dev@googlegroups.com),

Please take another look.

[nick1, 2013-09-10 21:29:02]

The first comment was incorporated into the change.

https://codereview.appspot.com/13427044/diff/5001/src/pkg/crypto/x509/x509.go
File src/pkg/crypto/x509/x509.go (right):

https://codereview.appspot.com/13427044/diff/5001/src/pkg/crypto/x509/x509.go...
src/pkg/crypto/x509/x509.go:48: func marshalPublicKey(pub interface{})
(publicKeyBytes []byte, err error) {
On 2013/09/10 16:27:23, agl1 wrote:
> extractPublicKeyAlgorithm should be merged into this function and this
function
> can return ([]byte, pkix.AlgorithmIdentifier, error). This saves an additional
> type switch and both callers are just calling one after the other already.

This makes sense, I have combined the two in the latest patch.

[agl1, 2013-09-11 14:53:46]

LGTM

[agl1, 2013-09-11 15:02:22]

Have you signed a CLA? http://golang.org/doc/contribute.html#copyright

[nick1, 2013-09-12 00:38:37]

Yes,

I believe it's under Nicholas Sullivan (nicholas.sullivan@gmail.com).

Nick

On Sep 11, 2013, at 11:02 AM, agl@golang.org wrote:

> Have you signed a CLA? http://golang.org/doc/contribute.html#copyright
> 
> https://codereview.appspot.com/13427044/

[agl1, 2013-09-12 16:23:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=3c075897aa0e ***

crypto/x509: allow ECDSA public keys to be marshaled.

The public key serialization from CreateCertificate is factored out to be
used in MarshalPKIXPublicKey.
Testcode with one P224 ECDSA keypair has been added.

R=golang-dev, agl
CC=agl, golang-dev
https://codereview.appspot.com/13427044

Committer: Adam Langley <agl@golang.org>