Issue 146260043: cloud/compute/metadata: Initial import of the package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146260043: cloud/compute/metadata: Initial import of the package

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by jbd

Modified:
11 years, 9 months ago

Reviewers:
adg, bradfitz

CC:
veneer-firehose_google.com

Visibility:
Public.

More Reviews

Description

cloud/compute/metadata: Initial import of the package

Patch Set 6 : #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -0 lines)			Patch
	A	compute/metadata/metadata.go	View	1 2 3 4 5	1 chunk	+217 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jbd

Importing Brad's gce package into the cloud package. I addressed the issues we've discussed earlier.

11 years, 9 months ago (2014-09-24 20:38:06 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/146260043/diff/80001/compute/metadata/metadata.go File compute/metadata/metadata.go (right): https://codereview.appspot.com/146260043/diff/80001/compute/metadata/metadata.go#newcode120 compute/metadata/metadata.go:120: res, err := metaClient.Get("http://metadata.google.internal") maybe add a comment ...

11 years, 9 months ago (2014-09-24 23:50:28 UTC) #3

jbd

11 years, 9 months ago (2014-09-25 01:59:37 UTC) #4

Submitted.

https://codereview.appspot.com/146260043/diff/80001/compute/metadata/metadata.go
File compute/metadata/metadata.go (right):

https://codereview.appspot.com/146260043/diff/80001/compute/metadata/metadata...
compute/metadata/metadata.go:120: res, err :=
metaClient.Get("http://metadata.google.internal")
On 2014/09/24 23:50:28, bradfitz wrote:
> maybe add a comment above this saying:
> 
>    // We use the DNS name of the metadata service here instead of the IP
address
>    // because we expect that to fail faster in the not-on-GCE case.

Done.

Expand All Messages | Collapse All Messages