code review 156540043: cmd/godoc: do not apply package path restrictions onto ...

cmd/godoc: do not apply package path restrictions onto GOROOT when indexing.

Fixes issue 6925.

[cronos, 2014-10-23 05:26:51]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-10-23 16:33:38]

LGTM

Would've preferred to see a test too, but looks right, and I verified it by
hand.



On Wed, Oct 22, 2014 at 10:26 PM, <Lytvynov.A.V@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> cmd/godoc: do not apply package path restrictions onto GOROOT when
> indexing.
>
> Fixes issue 6925.
>
> Please review this at https://codereview.appspot.com/156540043/
>
> Affected files (+2, -2 lines):
>   M godoc/dirtrees.go
>
>
> Index: godoc/dirtrees.go
> ===================================================================
> --- a/godoc/dirtrees.go
> +++ b/godoc/dirtrees.go
> @@ -179,8 +179,8 @@
>         case err != nil:
>                 log.Printf("newDirectory(%s): %s", root, err)
>                 return nil
> -       case !isPkgDir(d):
> -               log.Printf("newDirectory(%s): not a package directory",
> root)
> +       case !d.IsDir():
> +               log.Printf("newDirectory(%s): not a directory", root)
>                 return nil
>         }
>         if maxDepth < 0 {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[bradfitz, 2014-10-23 16:34:04]

*** Submitted as
https://code.google.com/p/go/source/detail?r=8688baf0f657&repo=tools ***

cmd/godoc: do not apply package path restrictions onto GOROOT when indexing.

Fixes issue 6925.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/156540043

Committer: Brad Fitzpatrick <bradfitz@golang.org>