code review 156610043: cmd/godoc: Allow custom GOOS/GOARCH from web page.

cmd/godoc: Allow custom GOOS/GOARCH from web page.

[larzconwell, 2014-10-25 00:45:13]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-10-25 21:30:17]

The tree is frozen right now. Please bring this up again after Go 1.4 is
out, around December 1st.


On Fri, Oct 24, 2014 at 5:45 PM, <larzconwell@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> cmd/godoc: Allow custom GOOS/GOARCH from web page.
>
> Please review this at https://codereview.appspot.com/156610043/
>
> Affected files (+16, -4 lines):
>   M cmd/godoc/doc.go
>   M godoc/pres.go
>   M godoc/server.go
>
>
> Index: cmd/godoc/doc.go
> ===================================================================
> --- a/cmd/godoc/doc.go
> +++ b/cmd/godoc/doc.go
> @@ -109,6 +109,11 @@
>  can be set with the -maxresults flag; if set to 0, no full text results
> are
>  shown, and only an identifier index but no full text search index is
> created.
>
> +By default, godoc uses the system's GOOS/GOARCH; in command-line mode you
> can
> +set the GOOS/GOARCH environment variables to get output for the system
> specified.
> +If -http was specified you can provide the URL parameters "goos" and
> "goarch"
> +to set the output on the web page.
> +
>  The presentation mode of web pages served by godoc can be controlled with
> the
>  "m" URL parameter; it accepts a comma-separated list of flag names as
> value:
>
> Index: godoc/pres.go
> ===================================================================
> --- a/godoc/pres.go
> +++ b/godoc/pres.go
> @@ -155,11 +155,11 @@
>  // TODO(bradfitz): move this to be a method on Corpus. Just moving code
> around for now,
>  // but this doesn't feel right.
>  func (p *Presentation) GetPkgPageInfo(abspath, relpath string, mode
> PageInfoMode) *PageInfo {
> -       return p.pkgHandler.GetPageInfo(abspath, relpath, mode)
> +       return p.pkgHandler.GetPageInfo(abspath, relpath, mode, "", "")
>  }
>
>  // TODO(bradfitz): move this to be a method on Corpus. Just moving code
> around for now,
>  // but this doesn't feel right.
>  func (p *Presentation) GetCmdPageInfo(abspath, relpath string, mode
> PageInfoMode) *PageInfo {
> -       return p.cmdHandler.GetPageInfo(abspath, relpath, mode)
> +       return p.cmdHandler.GetPageInfo(abspath, relpath, mode, "", "")
>  }
> Index: godoc/server.go
> ===================================================================
> --- a/godoc/server.go
> +++ b/godoc/server.go
> @@ -54,7 +54,7 @@
>  // directories, PageInfo.Dirs is nil. If an error occurred, PageInfo.Err
> is
>  // set to the respective error but the error is not logged.
>  //
> -func (h *handlerServer) GetPageInfo(abspath, relpath string, mode
> PageInfoMode) *PageInfo {
> +func (h *handlerServer) GetPageInfo(abspath, relpath string, mode
> PageInfoMode, goos, goarch string) *PageInfo {
>         info := &PageInfo{Dirname: abspath}
>
>         // Restrict to the package files that would be used when building
> @@ -84,6 +84,13 @@
>                 return ioutil.NopCloser(bytes.NewReader(data)), nil
>         }
>
> +       if goos != "" {
> +               ctxt.GOOS = goos
> +       }
> +       if goarch != "" {
> +               ctxt.GOARCH = goarch
> +       }
> +
>         pkginfo, err := ctxt.ImportDir(abspath, 0)
>         // continue if there are no Go source files; we still want the
> directory info
>         if _, nogo := err.(*build.NoGoError); err != nil && !nogo {
> @@ -242,7 +249,7 @@
>         if relpath == builtinPkgPath {
>                 mode = NoFiltering | NoTypeAssoc
>         }
> -       info := h.GetPageInfo(abspath, relpath, mode)
> +       info := h.GetPageInfo(abspath, relpath, mode, r.FormValue("goos"),
> r.FormValue("goarch"))
>         if info.Err != nil {
>                 log.Print(info.Err)
>                 h.p.ServeError(w, r, relpath, info.Err)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[gobot, 2014-12-19 05:14:16]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/156610043 is best) in the description in your
new CL.

Thanks very much.