Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(375)

Issue 163690043: code review 163690043: cmd/go: fixed typo in doc and generator

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by gbbr
Modified:
11 years, 8 months ago
Reviewers:
iant
CC:
golang-codereviews, iant, bradfitz
Visibility:
Public.

Description

cmd/go: fixed typo in doc and generator

Patch Set 1 #

Patch Set 2 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Patch Set 3 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Patch Set 4 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/go/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/go/generate.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
gbbr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 8 months ago (2014-10-30 21:05:59 UTC) #1
iant
cmd/go/doc.go is a generated file. See the comment near the top. Would you mind fixing ...
11 years, 8 months ago (2014-10-31 00:17:40 UTC) #2
gbbr
Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
11 years, 8 months ago (2014-10-31 00:26:21 UTC) #3
gbbr
On 2014/10/31 00:26:21, gbbr wrote: > Hello mailto:golang-codereviews@googlegroups.com, mailto:iant@golang.org (cc: > mailto:golang-codereviews@googlegroups.com), > > Please ...
11 years, 8 months ago (2014-10-31 00:26:46 UTC) #4
iant
Thanks. Have you signed the CLA?
11 years, 8 months ago (2014-10-31 00:33:41 UTC) #5
gbbr
On 2014/10/31 00:33:41, iant wrote: > Thanks. Have you signed the CLA? No problem. Yes, ...
11 years, 8 months ago (2014-10-31 00:34:30 UTC) #6
gbbr
On 2014/10/31 00:34:30, gbbr wrote: > On 2014/10/31 00:33:41, iant wrote: > > Thanks. Have ...
11 years, 8 months ago (2014-10-31 08:33:18 UTC) #7
bradfitz
Ian, CLA verified and sent you https://codereview.appspot.com/166970043 ... feel free to submit it on my ...
11 years, 8 months ago (2014-10-31 13:26:45 UTC) #8
iant
On 2014/10/31 08:33:18, gbbr wrote: > On 2014/10/31 00:34:30, gbbr wrote: > > On 2014/10/31 ...
11 years, 8 months ago (2014-10-31 16:38:22 UTC) #9
iant
LGTM
11 years, 8 months ago (2014-10-31 16:38:26 UTC) #10
iant
11 years, 8 months ago (2014-10-31 16:38:42 UTC) #11
*** Submitted as https://code.google.com/p/go/source/detail?r=1cf1a3d86986 ***

cmd/go: fixed typo in doc and generator

LGTM=iant
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/163690043

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b