Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(400)

Issue 30460043: code review 30460043: cgo/runtime: replace sigprocmask() with pthread_sigmask().

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by caglar10ur
Modified:
12 years, 6 months ago
Reviewers:
iant
CC:
jsing, iant, golang-codereviews, golang-dev
Visibility:
Public.

Description

cgo/runtime: replace sigprocmask() with pthread_sigmask(). sigprocmask() use in a multithreaded environment is undefined so replace it with pthread_sigmask(). Fixes issue 6811.

Patch Set 1 #

Patch Set 2 : diff -r 1140207a3395 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M src/pkg/runtime/cgo/gcc_dragonfly_386.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_dragonfly_amd64.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_freebsd_386.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_freebsd_amd64.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_linux_386.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_linux_amd64.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_netbsd_386.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_netbsd_amd64.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_netbsd_arm.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_openbsd_386.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_openbsd_amd64.c View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
jsing
Please 'hg mail' this for review.
12 years, 6 months ago (2013-12-20 15:57:42 UTC) #1
jsing
Please 'hg mail' this for review.
12 years, 6 months ago (2013-12-20 15:57:43 UTC) #2
caglar10ur
Hi, I'd like you to review this change Description: cgo/runtime: replace sigprocmask() with pthread_sigmask(). sigprocmask() ...
12 years, 6 months ago (2013-12-21 19:33:18 UTC) #3
caglar10ur
Hi, [Looks like Rietveld web interface uses another email address to CC code reviews. I'm ...
12 years, 6 months ago (2013-12-21 19:40:21 UTC) #4
iant
LGTM In change description, s/()//. Have you signed the CLA? (I haven't checked.) Thanks.
12 years, 6 months ago (2013-12-22 00:47:34 UTC) #5
caglar10ur
Hi Ian, On 2013/12/22 00:47:34, iant wrote: > LGTM > > In change description, s/()//. ...
12 years, 6 months ago (2013-12-22 01:10:00 UTC) #6
iant
12 years, 6 months ago (2013-12-22 16:55:31 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=042402c60017 ***

cgo/runtime: replace sigprocmask with pthread_sigmask.

sigprocmask use in a multithreaded environment is undefined so replace it with
pthread_sigmask.

Fixes issue 6811.

R=jsing, iant
CC=golang-codereviews, golang-dev
https://codereview.appspot.com/30460043

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b