Issue 5500097: vac: fix segfault on DMSYMLINK and DMDEVICE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5500097: vac: fix segfault on DMSYMLINK and DMDEVICE

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by 0intro

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Description

Fix segfault when the first archived file is DMSYMLINK or DMDEVICE. Reinitialize the buffer to zero before calling readlink.

Patch Set 1 #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/cmd/vac/vac.c	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

14 years, 5 months ago (2012-01-16 22:06:43 UTC) #2

*** Submitted as 8dfddf14ba55 ***

vac: fix segfault on DMSYMLINK or DMDEVICE

Fix segfault when the first archived file is DMSYMLINK or DMDEVICE.
Reinitialize the buffer to zero before calling readlink.

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5500097

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages