Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 5555073: code review 5555073: misc/emacs: Added an emacs flymake support module.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by LClarkMichalek
Modified:
14 years, 5 months ago
Reviewers:
fw, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

misc/emacs: Added an emacs flymake support module. Flymake is the emacs minor mode to run basic syntax checking over a file as you type. In the case of Go, the go compiler fits the job quite well; it's fast, and provides decent error messages. The added file deduces the name of the Go compiler from the architecture of the machine. This means that if the machine only has the compiler for a different architecture installed, the mode will fail. It also doesn't support gccgo, but customisation of the compiler/checker used is quite simple (i.e. one line of lisp). The other assumption made is that the compiler will be on the system path. However, as the mode is optional, I don't think these are unreasonable.

Patch Set 1 #

Patch Set 2 : diff -r ff82daa904d8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ff82daa904d8 https://go.googlecode.com/hg/ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A misc/emacs/flymake-go.el View 1 1 chunk +34 lines, -0 lines 2 comments Download

Messages

Total messages: 5
LClarkMichalek
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 5 months ago (2012-01-22 19:13:04 UTC) #1
fw
http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el File misc/emacs/flymake-go.el (right): http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el#newcode15 misc/emacs/flymake-go.el:15: (defvar go-compiler Is it possible to query this value ...
14 years, 5 months ago (2012-01-22 21:50:58 UTC) #2
LClarkMichalek
http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el File misc/emacs/flymake-go.el (right): http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el#newcode15 misc/emacs/flymake-go.el:15: (defvar go-compiler On 2012/01/22 21:50:58, fw wrote: > Is ...
14 years, 5 months ago (2012-01-22 22:38:06 UTC) #3
fw
On 2012/01/22 22:38:06, LClarkMichalek wrote: > http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el > File misc/emacs/flymake-go.el (right): > > http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el#newcode15 > ...
14 years, 5 months ago (2012-01-23 07:22:21 UTC) #4
LClarkMichalek
14 years, 5 months ago (2012-01-24 16:22:35 UTC) #5
On 2012/01/23 07:22:21, fw wrote:
> On 2012/01/22 22:38:06, LClarkMichalek wrote:
> > http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el
> > File misc/emacs/flymake-go.el (right):
> > 
> >
>
http://codereview.appspot.com/5555073/diff/1002/misc/emacs/flymake-go.el#newc...
> > misc/emacs/flymake-go.el:15: (defvar go-compiler
> > On 2012/01/22 21:50:58, fw wrote:
> > > Is it possible to query this value from the Go environment instead,
perhaps
> > > using the "go" tool?
> > 
> > What do you mean by the go tool? I've never heard of it before, and can't
find
> > any mention of it elsewhere.
> 
> The tool has been part of a few weekly releases.  It's command names are
> architecture-agnostic, so it needs to know about 5g/6g/8g internally.  I was
> wondering if you could get the information from there.  Come to think of it,
you
> should probably call "go build" instead of the compiler itself because that
> should take care of paths etc.
> 
> http://weekly.golang.org/cmd/go/

Ah, that looks like a useful tool. However, it dosn't seem to solve the multiple
file problem, as it can't automatically find all required files for building the
package, and if given the package name to build, the $GOPATH needs to be set up
correctly, which seems rather complicated. However, I have no experience with
it, and I'm not 100% sure which method is prefered.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b