Tidying

[ekasper, 2012-03-06 18:45:26]

LGTM modulo propagating the changes all the way up.

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLogger.h
File src/merkletree/TreeLogger.h (right):

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLogger.h#n...
src/merkletree/TreeLogger.h:51: size_t PendingLogSize() const { return
db_->PendingLogSize(); }
ct-server uses LogSize()...
(Please make sure both server and client still compile.)

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLoggerTest.cc
File src/merkletree/TreeLoggerTest.cc (right):

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLoggerTest...
src/merkletree/TreeLoggerTest.cc:52: static const char *nibble =
"0123456789abcdef";
Why make these static and not anything else?

In general, tests already live in unnamed namespace... (sigh, here we go again)

[ben, 2012-03-07 13:57:35]

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLogger.h
File src/merkletree/TreeLogger.h (right):

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLogger.h#n...
src/merkletree/TreeLogger.h:51: size_t PendingLogSize() const { return
db_->PendingLogSize(); }
On 2012/03/06 18:45:26, ekasper wrote:
> ct-server uses LogSize()...
> (Please make sure both server and client still compile.)

Done.

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLoggerTest.cc
File src/merkletree/TreeLoggerTest.cc (right):

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLoggerTest...
src/merkletree/TreeLoggerTest.cc:52: static const char *nibble =
"0123456789abcdef";
On 2012/03/06 18:45:26, ekasper wrote:
> Why make these static and not anything else?

They seemed obviously local. 

> 
> In general, tests already live in unnamed namespace... (sigh, here we go
again)

I have yet to understand why this is considered better, or even as good. Looking
at this declaration, how can I tell it is in an unnamed namespace?

[ekasper, 2012-03-07 14:48:07]

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLoggerTest.cc
File src/merkletree/TreeLoggerTest.cc (right):

http://codereview.appspot.com/5757052/diff/3001/src/merkletree/TreeLoggerTest...
src/merkletree/TreeLoggerTest.cc:52: static const char *nibble =
"0123456789abcdef";
On 2012/03/07 13:57:35, ben wrote:
> On 2012/03/06 18:45:26, ekasper wrote:
> > Why make these static and not anything else?
> 
> They seemed obviously local. 
> 
> > 
> > In general, tests already live in unnamed namespace... (sigh, here we go
> again)
> 
> I have yet to understand why this is considered better, or even as good.
Looking
> at this declaration, how can I tell it is in an unnamed namespace?

Don't know (perhaps because you can also put classes in an unnamed namespace?)
but I guess we should be consistent, and having both makes no sense. So if you
tidy this, tidy everything, everywhere :)