Issue 6554080: Rename FileDB -> FileStorage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6554080: Rename FileDB -> FileStorage

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Ben Laurie (Google)

Modified:
13 years, 9 months ago

Reviewers:
ekasper

Visibility:
Public.

More Reviews

Description

Rename FileDB -> FileStorage

Patch Set 1 #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -149 lines)			Patch
M	src/log/certificate_db.h	View	4 chunks	+6 lines, -4 lines	1 comment	Download
M	src/log/certificate_db.cc	View	10 chunks	+26 lines, -21 lines	0 comments	Download
M	src/log/certificate_db_test.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/log/file_db.h	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/log/file_db.cc	View	11 chunks	+24 lines, -24 lines	0 comments	Download
M	src/log/file_db_test.cc	View	8 chunks	+87 lines, -87 lines	0 comments	Download
M	src/log/frontend_signer_test.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/server/ct-server.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ekasper

13 years, 9 months ago (2012-09-24 15:40:10 UTC) #2

LGTM

https://codereview.appspot.com/6554080/diff/1/src/log/certificate_db.h
File src/log/certificate_db.h (right):

https://codereview.appspot.com/6554080/diff/1/src/log/certificate_db.h#newcode26
src/log/certificate_db.h:26: // Takes ownership of |cert_db|.
nit: cert_db -> storage (to match the .cc)

Expand All Messages | Collapse All Messages