Issue 6571064: code review 6571064: go.net/websocket: Use protocol parameter in websocket.Dial.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6571064: code review 6571064: go.net/websocket: Use protocol parameter in websocket.Dial.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by ukai

Modified:
13 years, 8 months ago

Reviewers:
rsc, mikio

CC:
golang-dev, rsc, mikio

Visibility:
Public.

Description

go.net/websocket: Use protocol parameter in websocket.Dial. Fixes issue 4157

Patch Set 1 #

Patch Set 2 : diff -r 7336440da745 https://code.google.com/p/go.net/ #

Patch Set 3 : diff -r 7336440da745 https://code.google.com/p/go.net/ #

Patch Set 4 : diff -r 7336440da745 https://code.google.com/p/go.net/ #

Patch Set 5 : diff -r 7336440da745 https://code.google.com/p/go.net/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	websocket/client.go	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ukai

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net/

13 years, 9 months ago (2012-09-27 02:39:42 UTC) #1

mikio

13 years, 8 months ago (2012-10-09 22:45:14 UTC) #4

*** Submitted as
http://code.google.com/p/go/source/detail?r=b083464e52c5&repo=net ***

go.net/websocket: Use protocol parameter in websocket.Dial.

Fixes issue 4157

R=golang-dev, rsc, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/6571064

Committer: Mikio Hara <mikioh.mikioh@gmail.com>

Expand All Messages | Collapse All Messages