Issue 8028043: Lift some more precert handling into certchecker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by ekasper

Modified:
13 years, 3 months ago

Reviewers:
Ben Laurie (Google)

CC:
Al Cutter

Visibility:
Public.

Lift some more precert handling into certchecker

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -80 lines)			Patch
M	src/client/json_wrapper.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/log/cert.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/log/cert_checker.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	src/log/cert_checker.cc	View	1	5 chunks	+55 lines, -12 lines	0 comments	Download
M	src/log/cert_checker_test.cc	View	1	2 chunks	+39 lines, -5 lines	0 comments	Download
M	src/log/cert_submission_handler.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/log/cert_submission_handler.cc	View		3 chunks	+7 lines, -59 lines	0 comments	Download

Total messages: 2

ekasper

- Lift the code that extracts relevant precert components into CertChecker - Try to be ...

13 years, 3 months ago (2013-03-26 11:32:54 UTC) #1

LGTM.