Make SkCreateCGImageRef() work with a non-default channel config

This is required for the chromium patch http://codereview.chromium.org/141037 .

[thomasvl, 2009-06-22 15:28:32]

drive by: make sure you run the layout tests with pixel diffs turned on so it
looks at the crcs.  They crc is run over the raw image data, so it needs to be
in the right layout.

[thakis, 2009-06-22 16:56:57]

This is required for a Chromium patch ( http://codereview.chromium.org/141037 ).

Not sure what the best way is to land this, as chrome won't compile if this
lands first, and chrome's tests will fail if the chrome patch lands first. How
is this usually done?

[jrg, 2009-06-22 18:13:35]

Idea for landing:
Land in Skia.  Add DEPS file update to your other CL so it comes in in sync.

[thakis, 2009-06-22 18:14:20]

I changed the #error into a #warning, so that this doesn't break the chrome mac
build when this lands. This way, it's possible to commit this to skia, roll the
skia deps in chromium, and then land the chromium part of this CL.

This also has the advantage of not breaking the build of other projects that
might use this file with a non-default channel configuration (at the cost of not
really informing them of the broken cgimages they get from this function).

[reed, 2009-06-22 20:04:51]

patch submitted to skia/trunk

On 2009/06/22 18:14:20, thakis wrote:
> I changed the #error into a #warning, so that this doesn't break the chrome
mac
> build when this lands. This way, it's possible to commit this to skia, roll
the
> skia deps in chromium, and then land the chromium part of this CL.
> 
> This also has the advantage of not breaking the build of other projects that
> might use this file with a non-default channel configuration (at the cost of
not
> really informing them of the broken cgimages they get from this function).