Issue 90540043: http: close response body if unused

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90540043: http: close response body if unused

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by axw

Modified:
12 years, 2 months ago

Reviewers:
jameinel, mp+216822

Visibility:
Public.

Description

http: close response body if unused BinaryRequest calls may discard the response without closing it. This was causing sockets to be left open in juju-core/provider/openstack tests, leading to test failures. https://code.launchpad.net/~axwalk/goose/close-response/+merge/216822 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	http/client.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages