Skip to content

Add ArgoCD support#145

Merged
SimonBarendse merged 2 commits into
1Password:mainfrom
ssttehrani:ssttehrani/add-argocd
Jan 17, 2023
Merged

Add ArgoCD support#145
SimonBarendse merged 2 commits into
1Password:mainfrom
ssttehrani:ssttehrani/add-argocd

Conversation

@ssttehrani

Copy link
Copy Markdown
Contributor

This PR Adds support for Argo CD CLI and enables authentication using environment variable.

SimonBarendse
SimonBarendse previously approved these changes Jan 16, 2023

@SimonBarendse SimonBarendse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution! Thank you 🙌

@SimonBarendse SimonBarendse requested a review from DCKcode January 16, 2023 12:36
@DCKcode

DCKcode commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Thanks, looks good!

DCKcode
DCKcode previously approved these changes Jan 16, 2023
florisvdg
florisvdg previously approved these changes Jan 16, 2023
Comment thread plugins/argocd/auth_token.go Outdated
@ssttehrani ssttehrani dismissed stale reviews from florisvdg, DCKcode, and SimonBarendse via 4705d57 January 16, 2023 13:40
@SimonBarendse SimonBarendse merged commit 6f03497 into 1Password:main Jan 17, 2023
@ssttehrani ssttehrani deleted the ssttehrani/add-argocd branch January 17, 2023 11:35
@Priest94

This comment was marked as spam.

@Priest94

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants