Skip to content

feat: check for AWS_SHARED_CREDENTIALS_FILE#178

Merged
SimonBarendse merged 1 commit into
1Password:mainfrom
Volatus:fix/check-for-aws-creds-file
Feb 14, 2023
Merged

feat: check for AWS_SHARED_CREDENTIALS_FILE#178
SimonBarendse merged 1 commit into
1Password:mainfrom
Volatus:fix/check-for-aws-creds-file

Conversation

@Volatus

@Volatus Volatus commented Feb 12, 2023

Copy link
Copy Markdown
Contributor

Check if the environment has set this variable and if so, attempt the
import using that file.

Signed-off-by: Ismayil Mirzali ismayilmirzeli@gmail.com

@Volatus Volatus force-pushed the fix/check-for-aws-creds-file branch from f445a91 to d44f5ea Compare February 12, 2023 23:22
Check if the environment has set this variable and if so, attempt the
import using that file.

Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
@Volatus Volatus force-pushed the fix/check-for-aws-creds-file branch from d44f5ea to 948c882 Compare February 12, 2023 23:22

@AndyTitu AndyTitu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise

@DCKcode DCKcode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! GIven that this configuration is respected by the AWS CLI, it makes sense to respect it here as well.

@SimonBarendse SimonBarendse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Volatus! ❤️

@SimonBarendse SimonBarendse merged commit 384c352 into 1Password:main Feb 14, 2023
@Volatus Volatus deleted the fix/check-for-aws-creds-file branch February 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants