Skip to content

Add support for Kaggle CLI#341

Merged
arunsathiya merged 4 commits into
1Password:mainfrom
rajapri28613:kaggle
Jul 25, 2023
Merged

Add support for Kaggle CLI#341
arunsathiya merged 4 commits into
1Password:mainfrom
rajapri28613:kaggle

Conversation

@rajapri28613

Copy link
Copy Markdown
Contributor

Overview

Add support for Kaggle CLI. Kaggle CLI supports environment variables KAGGLE_KEY and KAGGLE_USERNAME

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install Kaggle CLI and set up shell plugin.
  • Run op plugin init kaggle to configure username and Kaggle API Key.
  • Future queries should use these credentials.

Changelog

Add support for Kaggle.

Additional information

@rajapri28613

Copy link
Copy Markdown
Contributor Author

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
@hculea hculea requested a review from AndyTitu July 5, 2023 07:31

@arunsathiya arunsathiya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, thanks @rajapri28613! Only one comment about adding support for config file importer.

Comment thread plugins/kaggle/api_token_test.go
Comment thread plugins/kaggle/api_token.go
@arunsathiya arunsathiya self-requested a review July 12, 2023 11:57
@accraw accraw added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 14, 2023
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 19, 2023

@arunsathiya arunsathiya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config file importer works and code changes look good to me. Thanks for your contribution, @rajapri28613!

@accraw accraw added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 24, 2023

@SimonBarendse SimonBarendse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your contribution!

I have left a tiny suggestion for your consideration.

Comment thread plugins/kaggle/api_token.go Outdated
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
@arunsathiya arunsathiya merged commit 0b46a42 into 1Password:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants