ARROW-12686: [C++][Python][FlightRPC] Convert Flight reader into a regular reader#10267
Closed
lidavidm wants to merge 1 commit into
Closed
ARROW-12686: [C++][Python][FlightRPC] Convert Flight reader into a regular reader#10267lidavidm wants to merge 1 commit into
lidavidm wants to merge 1 commit into
Conversation
westonpace
approved these changes
May 11, 2021
westonpace
left a comment
Member
There was a problem hiding this comment.
Looks good, just one thought but not necessary IMO.
Member
There was a problem hiding this comment.
Nit: Perhaps add a note that it does this by first reading the schema or some kind of indication that calling to_reader will cause it to read the schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides compatibility with APIs that expect regular RecordBatchReaders, e.g. exporting via the C Data Interface. The Flight interface itself cannot implement RecordBatchReader because getting the schema is not an infallible operation.