ARROW-13645 [Java]: Allow NullVectors to have distinct field names#10949
Closed
liyafan82 wants to merge 1 commit into
Closed
ARROW-13645 [Java]: Allow NullVectors to have distinct field names#10949liyafan82 wants to merge 1 commit into
liyafan82 wants to merge 1 commit into
Conversation
Member
|
LGTM |
Contributor
Author
@kiszk Thanks for your feedback. I have updated the description accordingly. |
Member
|
I still see |
kiszk
approved these changes
Aug 23, 2021
Contributor
Author
@kiszk Thanks for your careful review. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
As discussed in the ML (https://lists.apache.org/thread.html/r19aad8a34f63334d3fcd627106f69be13f689740b83930a4eecc17b3%40%3Cdev.arrow.apache.org%3E), the current implementation use hard-coded field names. This may cause some problems, for example, when reconstruct a usable schema from a list of FieldVectors. So we resolve this problem by allowing NullVectors to have distinct field names. This also makes the `NullVector` consistent with other types of vectors. Closes apache#10949 from liyafan82/fly_0817_zr Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: liyafan82 <fan_li_ya@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the ML (https://lists.apache.org/thread.html/r19aad8a34f63334d3fcd627106f69be13f689740b83930a4eecc17b3%40%3Cdev.arrow.apache.org%3E), the current implementation use hard-coded field names. This may cause some problems, for example, when reconstruct a usable schema from a list of FieldVectors.
So we resolve this problem by allowing NullVectors to have distinct field names.
This also makes the
NullVectorconsistent with other types of vectors.