ARROW-3455: [Gandiva][C++] Support pkg-config for Gandiva#2729
Closed
shiro615 wants to merge 2 commits into
Closed
ARROW-3455: [Gandiva][C++] Support pkg-config for Gandiva#2729shiro615 wants to merge 2 commits into
shiro615 wants to merge 2 commits into
Conversation
kou
approved these changes
Oct 9, 2018
| includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@ | ||
|
|
||
| Name: Gandiva | ||
| Description: Gandiva is a toolset for compiling and evaluating expressions on arrow data. |
Member
There was a problem hiding this comment.
Can you use "Arrow" instead of "arrow"?
Contributor
Author
There was a problem hiding this comment.
Thank you for your comment.
I've fixed this.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we can detect whether Gandiva are built or not by pkg-config.