Skip to content

ARROW-3661: [Gandiva][GLib] Use "_" as word separator in constant name#2881

Closed
kou wants to merge 1 commit into
apache:masterfrom
kou:glib-improve-name
Closed

ARROW-3661: [Gandiva][GLib] Use "_" as word separator in constant name#2881
kou wants to merge 1 commit into
apache:masterfrom
kou:glib-improve-name

Conversation

@kou

@kou kou commented Oct 31, 2018

Copy link
Copy Markdown
Member

No description provided.

@kou

kou commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

@shiro615 Can you review this?

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2881 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2881      +/-   ##
==========================================
- Coverage   87.58%   87.57%   -0.02%     
==========================================
  Files         412      412              
  Lines       64036    64036              
==========================================
- Hits        56084    56077       -7     
- Misses       7882     7885       +3     
- Partials       70       74       +4
Impacted Files Coverage Δ
go/arrow/math/int64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_amd64.go 28.57% <0%> (-14.29%) ⬇️
go/arrow/math/math_amd64.go 31.57% <0%> (-5.27%) ⬇️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
cpp/src/arrow/csv/column-builder.cc 97.1% <0%> (+2.17%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059e2d0...73a3c50. Read the comment docs.

@shiro615 shiro615 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenbingo praveenbingo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review +1.

@xhochy xhochy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 2ac04fd Oct 31, 2018
@kou kou deleted the glib-improve-name branch November 1, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants