ARROW-3831: [C++] Add support for returning decompressed size

[kou]

No description provided.

[wesm]

[ RUN      ] TestGZip/CodecTest.CodecRoundtrip/0
..\src\arrow\util\compression-test.cc(88): error:       Expected: data.size()
      Which is: 0
To be equal to: actual_decompressed_size
      Which is: -3689348814741910324
..\src\arrow\util\compression-test.cc(88): error:       Expected: data.size()
      Which is: 0
To be equal to: actual_decompressed_size
      Which is: -3689348814741910324

[codecov-io]

Codecov Report

Merging #3024 into master will increase coverage by 1.08%.
The diff coverage is 90.74%.

@@            Coverage Diff             @@
##           master    #3024      +/-   ##
==========================================
+ Coverage   86.94%   88.03%   +1.08%     
==========================================
  Files         494      425      -69     
  Lines       70180    64841    -5339     
==========================================
- Hits        61018    57081    -3937     
+ Misses       9066     7760    -1306     
+ Partials       96        0      -96

Impacted Files	Coverage Δ
cpp/src/arrow/util/compression_bz2.h	50% <ø> (ø)	⬆️
cpp/src/arrow/util/compression_brotli.h	50% <ø> (ø)	⬆️
cpp/src/arrow/util/compression_snappy.h	50% <ø> (ø)	⬆️
cpp/src/arrow/util/compression.h	100% <ø> (ø)	⬆️
cpp/src/arrow/util/compression_lz4.h	50% <ø> (ø)	⬆️
cpp/src/arrow/util/compression_zstd.h	50% <ø> (ø)	⬆️
cpp/src/arrow/util/compression_bz2.cc	57.02% <0%> (-0.96%)	⬇️
cpp/src/arrow/util/compression_lz4.cc	74.78% <100%> (+0.87%)	⬆️
cpp/src/arrow/util/compression-test.cc	99.12% <100%> (+0.02%)	⬆️
cpp/src/arrow/util/compression_zstd.cc	92.07% <100%> (+0.32%)	⬆️
... and 88 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0958a...9b16e58. Read the comment docs.

[kou]

I've fixed it.

[wesm]

+1. Thanks @kou! I opened https://issues.apache.org/jira/browse/ARROW-3877 about also adding support for decompression output size hints (which are provided by some of these libraries)

[pitrou]

You don't check that output_buffer_len is large enough here?

[pitrou]

It would be useful to test what happens if the size is wrong...

[wesm]

I opened https://issues.apache.org/jira/browse/ARROW-3886 about adding another test

[kou]

I've created a pull request for it: #3057