Skip to content

[fix](be) Add explicit template instantiation for BlockFileCache::get_cell#64228

Open
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/tsan-get-cell-link-error
Open

[fix](be) Add explicit template instantiation for BlockFileCache::get_cell#64228
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/tsan-get-cell-link-error

Conversation

@heguanhui

@heguanhui heguanhui commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #64227

Related PR: #xxx

Problem Summary: When building BE UT with TSAN, the linker reports undefined symbol for BlockFileCache::get_cell<std::lock_guard<std::mutex>>. The template function get_cell is defined in block_file_cache.cpp but lacks explicit template instantiation. Non-TSAN builds may inline the template, masking the issue, but TSAN disables inlining, exposing the missing symbol.

normal log after fix:
tsan_get_cell_link_error_TSAN.log

The same pattern already exists for the remove template function (block_file_cache.cpp:2515) and LRUQueue templates (file_cache_common.cpp:149-150). get_cell is simply missing the same explicit instantiation.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb zclllyybb mentioned this pull request Jun 8, 2026
Open
2 tasks
@heguanhui

heguanhui commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.83% (28276/38298)
Line Coverage 57.85% (307672/531853)
Region Coverage 54.71% (257887/471332)
Branch Coverage 56.07% (111826/199431)

@hello-stephen

hello-stephen commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29341 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5c59427efeaac5c2491ad57da6ce9039115300f3, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17615	4188	4122	4122
q2	q3	10766	1400	817	817
q4	4689	504	363	363
q5	7543	884	592	592
q6	185	183	141	141
q7	795	884	619	619
q8	9341	1626	1614	1614
q9	5840	4591	4507	4507
q10	6743	1817	1534	1534
q11	438	277	255	255
q12	627	441	317	317
q13	18135	3507	2733	2733
q14	266	262	242	242
q15	q16	820	773	717	717
q17	985	883	904	883
q18	7162	5760	5517	5517
q19	1163	1424	1124	1124
q20	509	438	264	264
q21	6225	2864	2672	2672
q22	472	375	308	308
Total cold run time: 100319 ms
Total hot run time: 29341 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	5382	4948	4898	4898
q2	q3	4902	5301	4751	4751
q4	2148	2209	1420	1420
q5	4920	4899	4793	4793
q6	256	201	135	135
q7	1911	1799	1652	1652
q8	2686	2223	2196	2196
q9	8181	7999	7579	7579
q10	4784	4780	4365	4365
q11	539	390	355	355
q12	742	757	536	536
q13	3047	3532	2803	2803
q14	273	281	253	253
q15	q16	689	698	615	615
q17	1304	1277	1273	1273
q18	7333	6852	6851	6851
q19	1134	1076	1097	1076
q20	2251	2241	1961	1961
q21	5302	4619	4535	4535
q22	504	450	418	418
Total cold run time: 58288 ms
Total hot run time: 52465 ms

@hello-stephen

hello-stephen commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 169194 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5c59427efeaac5c2491ad57da6ce9039115300f3, data reload: false

query5	4353	662	502	502
query6	461	206	186	186
query7	4867	548	295	295
query8	378	229	210	210
query9	8783	4008	4026	4008
query10	481	318	269	269
query11	5934	2357	2120	2120
query12	166	107	106	106
query13	1283	598	440	440
query14	6427	5450	5103	5103
query14_1	4418	4411	4396	4396
query15	214	203	186	186
query16	1046	467	449	449
query17	1130	728	580	580
query18	2716	480	359	359
query19	213	187	146	146
query20	114	107	107	107
query21	222	143	124	124
query22	13701	13657	13417	13417
query23	17470	16551	16142	16142
query23_1	16207	16354	16287	16287
query24	7740	1777	1319	1319
query24_1	1327	1320	1318	1318
query25	598	481	416	416
query26	1323	318	172	172
query27	2544	579	348	348
query28	4420	1997	2047	1997
query29	1125	632	516	516
query30	312	237	204	204
query31	1133	1082	952	952
query32	106	63	62	62
query33	542	368	253	253
query34	1210	1126	661	661
query35	754	775	694	694
query36	1398	1415	1248	1248
query37	155	102	89	89
query38	3210	3144	3049	3049
query39	933	915	918	915
query39_1	876	872	876	872
query40	227	119	98	98
query41	64	64	62	62
query42	96	97	93	93
query43	318	323	280	280
query44	
query45	199	190	188	188
query46	1085	1226	727	727
query47	2419	2434	2276	2276
query48	405	379	282	282
query49	630	484	363	363
query50	998	354	261	261
query51	4395	4312	4268	4268
query52	90	87	76	76
query53	239	267	194	194
query54	264	212	193	193
query55	79	75	69	69
query56	232	223	223	223
query57	1408	1417	1334	1334
query58	250	218	216	216
query59	1542	1673	1440	1440
query60	289	259	231	231
query61	161	150	158	150
query62	693	648	587	587
query63	239	187	180	180
query64	2499	790	606	606
query65	
query66	1715	477	348	348
query67	29753	29647	29650	29647
query68	
query69	423	311	264	264
query70	961	960	970	960
query71	298	217	213	213
query72	2989	2732	2346	2346
query73	833	740	421	421
query74	5145	4934	4752	4752
query75	2650	2588	2224	2224
query76	2353	1146	785	785
query77	373	392	278	278
query78	12357	12468	11787	11787
query79	1374	1025	786	786
query80	593	482	395	395
query81	454	282	237	237
query82	564	154	120	120
query83	352	280	245	245
query84	
query85	877	538	432	432
query86	369	313	276	276
query87	3394	3401	3178	3178
query88	3598	2764	2719	2719
query89	425	392	327	327
query90	1998	181	188	181
query91	176	161	139	139
query92	66	65	58	58
query93	1487	1518	869	869
query94	540	362	327	327
query95	707	389	440	389
query96	1055	823	323	323
query97	2721	2699	2568	2568
query98	212	209	203	203
query99	1182	1173	1027	1027
Total cold run time: 251627 ms
Total hot run time: 169194 ms

@heguanhui heguanhui force-pushed the fix/tsan-get-cell-link-error branch from 5c59427 to b51f3a0 Compare June 9, 2026 01:28
@heguanhui

heguanhui commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29056 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b51f3a0b3f34806e85cac6d5119b5ed8389239be, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17739	4042	4070	4042
q2	q3	10785	1349	819	819
q4	4692	469	342	342
q5	7581	866	598	598
q6	199	172	133	133
q7	780	844	655	655
q8	9928	1642	1752	1642
q9	7378	4478	4491	4478
q10	6814	1789	1572	1572
q11	436	269	252	252
q12	640	426	298	298
q13	18113	3705	2753	2753
q14	269	263	242	242
q15	q16	820	772	703	703
q17	1000	945	1033	945
q18	6830	5581	5571	5571
q19	1619	1300	1079	1079
q20	516	415	278	278
q21	5879	2582	2350	2350
q22	431	356	304	304
Total cold run time: 102449 ms
Total hot run time: 29056 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4385	4301	4311	4301
q2	q3	4500	4948	4288	4288
q4	2082	2216	1372	1372
q5	4450	4292	4314	4292
q6	231	174	127	127
q7	1782	2078	1774	1774
q8	2547	2418	2075	2075
q9	8007	7998	7963	7963
q10	4829	4756	4301	4301
q11	590	421	547	421
q12	750	741	538	538
q13	3219	3629	3090	3090
q14	307	314	285	285
q15	q16	723	769	651	651
q17	1347	1305	1354	1305
q18	7863	7388	6876	6876
q19	1176	1071	1090	1071
q20	2217	2219	1935	1935
q21	5330	4561	4389	4389
q22	519	475	403	403
Total cold run time: 56854 ms
Total hot run time: 51457 ms

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 169804 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b51f3a0b3f34806e85cac6d5119b5ed8389239be, data reload: false

query5	4324	647	482	482
query6	445	203	199	199
query7	4807	558	311	311
query8	369	217	212	212
query9	8763	4043	4030	4030
query10	445	323	255	255
query11	5920	2369	2146	2146
query12	153	103	100	100
query13	1285	596	425	425
query14	6422	5388	5092	5092
query14_1	4428	4445	4431	4431
query15	208	199	184	184
query16	1021	456	447	447
query17	1142	748	576	576
query18	2611	491	345	345
query19	196	185	145	145
query20	113	104	109	104
query21	227	140	115	115
query22	13664	13633	13447	13447
query23	17153	16542	16224	16224
query23_1	16333	16346	16419	16346
query24	7746	1768	1289	1289
query24_1	1287	1332	1300	1300
query25	563	447	397	397
query26	1356	312	165	165
query27	2597	551	341	341
query28	4457	1999	2013	1999
query29	1067	621	477	477
query30	302	248	198	198
query31	1103	1070	959	959
query32	105	61	58	58
query33	529	336	250	250
query34	1172	1139	666	666
query35	756	780	684	684
query36	1384	1374	1213	1213
query37	155	105	91	91
query38	3204	3189	3067	3067
query39	929	917	905	905
query39_1	880	889	876	876
query40	224	129	101	101
query41	65	62	62	62
query42	94	99	91	91
query43	315	328	283	283
query44	
query45	194	186	179	179
query46	1078	1227	761	761
query47	2372	2416	2200	2200
query48	379	399	287	287
query49	623	472	348	348
query50	960	368	258	258
query51	4390	4308	4302	4302
query52	87	89	78	78
query53	243	266	194	194
query54	265	222	211	211
query55	80	79	78	78
query56	239	235	232	232
query57	1427	1402	1325	1325
query58	245	224	215	215
query59	1580	1643	1488	1488
query60	286	247	238	238
query61	162	166	162	162
query62	708	658	565	565
query63	236	182	190	182
query64	2567	795	623	623
query65	
query66	1747	521	345	345
query67	29742	29737	29686	29686
query68	
query69	427	303	281	281
query70	989	948	925	925
query71	300	223	202	202
query72	3019	2681	2517	2517
query73	847	798	431	431
query74	5096	5018	4755	4755
query75	2654	2576	2236	2236
query76	2327	1155	781	781
query77	360	368	289	289
query78	12340	12360	11911	11911
query79	1255	1013	777	777
query80	575	504	408	408
query81	451	282	249	249
query82	305	161	130	130
query83	369	294	259	259
query84	
query85	984	610	525	525
query86	379	301	271	271
query87	3411	3378	3184	3184
query88	3627	2742	2746	2742
query89	423	388	336	336
query90	1812	187	186	186
query91	195	179	159	159
query92	67	64	59	59
query93	1500	1457	901	901
query94	570	381	317	317
query95	704	404	354	354
query96	999	830	340	340
query97	2679	2669	2564	2564
query98	254	209	204	204
query99	1136	1181	1059	1059
Total cold run time: 250399 ms
Total hot run time: 169804 ms

@heguanhui

heguanhui commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@heguanhui heguanhui force-pushed the fix/tsan-get-cell-link-error branch from b51f3a0 to 17e274c Compare June 13, 2026 15:10
@heguanhui

heguanhui commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28923 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17e274c04a75137e70e8681eeebd61415624f222, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17767	4023	4109	4023
q2	q3	10749	1326	807	807
q4	4690	474	346	346
q5	7572	856	569	569
q6	183	177	148	148
q7	773	835	633	633
q8	9387	1500	1612	1500
q9	6434	4448	4474	4448
q10	6810	1801	1543	1543
q11	436	272	254	254
q12	644	428	288	288
q13	18110	3434	2776	2776
q14	276	258	242	242
q15	q16	813	771	713	713
q17	1223	969	907	907
q18	6932	5759	5462	5462
q19	1398	1279	1062	1062
q20	498	400	263	263
q21	6076	2848	2616	2616
q22	454	376	323	323
Total cold run time: 101225 ms
Total hot run time: 28923 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4829	4850	4706	4706
q2	q3	5075	5178	4525	4525
q4	2132	2183	1389	1389
q5	4906	4724	4802	4724
q6	237	182	138	138
q7	1892	1703	1576	1576
q8	2475	2207	2173	2173
q9	7424	7370	7266	7266
q10	4753	4681	4208	4208
q11	542	404	368	368
q12	726	742	538	538
q13	2974	3267	2828	2828
q14	284	272	259	259
q15	q16	686	699	621	621
q17	1295	1263	1254	1254
q18	7359	6840	7074	6840
q19	1108	1092	1092	1092
q20	2226	2224	1931	1931
q21	5326	4687	4546	4546
q22	562	456	400	400
Total cold run time: 56811 ms
Total hot run time: 51382 ms

@hello-stephen

hello-stephen commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 168950 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17e274c04a75137e70e8681eeebd61415624f222, data reload: false

query5	4298	645	470	470
query6	449	198	169	169
query7	4829	550	311	311
query8	355	215	200	200
query9	8755	4086	4068	4068
query10	436	312	251	251
query11	5909	2398	2121	2121
query12	159	103	99	99
query13	1279	650	403	403
query14	6384	5424	5106	5106
query14_1	4435	4400	4411	4400
query15	199	192	168	168
query16	988	443	425	425
query17	1092	682	566	566
query18	2548	464	321	321
query19	187	182	138	138
query20	108	104	99	99
query21	214	137	117	117
query22	13664	13608	13487	13487
query23	17341	16427	16237	16237
query23_1	16330	16337	16313	16313
query24	7587	1750	1287	1287
query24_1	1299	1283	1309	1283
query25	548	438	384	384
query26	1299	326	167	167
query27	2675	573	332	332
query28	4462	2038	1995	1995
query29	1088	600	453	453
query30	296	232	202	202
query31	1117	1056	943	943
query32	111	61	56	56
query33	524	308	235	235
query34	1164	1136	650	650
query35	749	766	676	676
query36	1382	1448	1281	1281
query37	152	103	90	90
query38	3227	3147	3036	3036
query39	919	921	887	887
query39_1	874	878	860	860
query40	215	122	95	95
query41	63	65	59	59
query42	93	100	98	98
query43	326	330	292	292
query44	
query45	194	183	175	175
query46	1095	1188	748	748
query47	2318	2343	2308	2308
query48	390	436	301	301
query49	642	465	344	344
query50	982	357	262	262
query51	4239	4347	4268	4268
query52	87	86	74	74
query53	241	273	197	197
query54	270	216	194	194
query55	81	76	68	68
query56	239	226	204	204
query57	1444	1407	1292	1292
query58	252	208	212	208
query59	1614	1703	1479	1479
query60	274	237	223	223
query61	161	176	176	176
query62	699	650	590	590
query63	235	190	191	190
query64	2432	829	664	664
query65	
query66	1776	462	353	353
query67	29639	29549	29425	29425
query68	
query69	429	302	271	271
query70	1011	1012	943	943
query71	319	229	216	216
query72	2991	2604	2267	2267
query73	828	825	460	460
query74	5141	4944	4793	4793
query75	2631	2539	2228	2228
query76	2331	1160	796	796
query77	348	399	295	295
query78	12369	12329	11861	11861
query79	1502	1048	731	731
query80	1220	455	391	391
query81	530	280	243	243
query82	620	160	119	119
query83	324	272	243	243
query84	
query85	938	504	414	414
query86	424	301	288	288
query87	3396	3369	3209	3209
query88	3721	2758	2708	2708
query89	428	381	326	326
query90	1882	174	178	174
query91	172	155	130	130
query92	58	57	53	53
query93	1624	1488	840	840
query94	753	346	308	308
query95	691	458	330	330
query96	1051	783	351	351
query97	2693	2703	2536	2536
query98	216	206	203	203
query99	1156	1182	1023	1023
Total cold run time: 251564 ms
Total hot run time: 168950 ms

@heguanhui heguanhui force-pushed the fix/tsan-get-cell-link-error branch from 17e274c to 83f03d5 Compare June 16, 2026 13:18
@heguanhui

heguanhui commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28878 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83f03d5d0529d859d941430873ea89a60dbab7d3, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17794	4019	3945	3945
q2	2015	299	192	192
q3	10348	1430	794	794
q4	4674	462	335	335
q5	7611	844	572	572
q6	181	175	140	140
q7	760	838	624	624
q8	9586	1572	1612	1572
q9	6377	4485	4481	4481
q10	6826	1780	1510	1510
q11	440	278	243	243
q12	637	419	300	300
q13	18129	3482	2756	2756
q14	280	259	248	248
q15	q16	795	783	709	709
q17	1356	912	860	860
q18	6902	5769	5565	5565
q19	1407	1251	1042	1042
q20	475	406	269	269
q21	5535	2594	2419	2419
q22	433	364	302	302
Total cold run time: 102561 ms
Total hot run time: 28878 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4310	4428	4239	4239
q2	335	360	219	219
q3	4617	4904	4379	4379
q4	2045	2144	1355	1355
q5	4430	4249	4292	4249
q6	224	174	124	124
q7	1707	2048	1752	1752
q8	2476	2191	2019	2019
q9	7857	7878	7852	7852
q10	4832	4739	4345	4345
q11	553	423	378	378
q12	740	749	616	616
q13	3423	3596	3090	3090
q14	312	292	268	268
q15	q16	715	751	650	650
q17	1351	1326	1313	1313
q18	7943	7222	7259	7222
q19	1128	1113	1129	1113
q20	2208	2218	1951	1951
q21	5249	4539	4355	4355
q22	505	456	427	427
Total cold run time: 56960 ms
Total hot run time: 51916 ms

@hello-stephen

hello-stephen commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 177416 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83f03d5d0529d859d941430873ea89a60dbab7d3, data reload: false

query5	4332	636	482	482
query6	440	198	172	172
query7	4837	542	308	308
query8	357	209	199	199
query9	8759	4031	4021	4021
query10	458	316	282	282
query11	5918	2333	2149	2149
query12	152	103	102	102
query13	1320	615	456	456
query14	6377	5441	5057	5057
query14_1	4380	4372	4383	4372
query15	201	198	172	172
query16	1003	443	428	428
query17	1091	672	547	547
query18	2663	475	334	334
query19	189	181	134	134
query20	110	108	102	102
query21	214	144	114	114
query22	13691	13514	13428	13428
query23	17568	16536	16225	16225
query23_1	16380	16260	16215	16215
query24	7481	1781	1282	1282
query24_1	1355	1296	1319	1296
query25	561	467	406	406
query26	1372	315	166	166
query27	2598	605	342	342
query28	4485	2054	2018	2018
query29	1093	628	503	503
query30	314	243	209	209
query31	1127	1085	961	961
query32	113	64	59	59
query33	542	345	266	266
query34	1197	1134	667	667
query35	749	778	686	686
query36	1407	1386	1248	1248
query37	151	107	92	92
query38	3226	3268	3128	3128
query39	1002	971	946	946
query39_1	924	940	911	911
query40	223	126	108	108
query41	69	66	66	66
query42	98	95	96	95
query43	336	344	290	290
query44	1481	817	801	801
query45	199	192	185	185
query46	1146	1259	773	773
query47	2463	2419	2320	2320
query48	436	437	302	302
query49	646	491	368	368
query50	1055	376	271	271
query51	4360	4467	4332	4332
query52	90	92	79	79
query53	265	265	194	194
query54	289	226	210	210
query55	87	76	72	72
query56	248	244	262	244
query57	1451	1418	1326	1326
query58	246	230	218	218
query59	1587	1678	1422	1422
query60	298	264	242	242
query61	176	198	150	150
query62	703	649	591	591
query63	232	186	192	186
query64	2314	758	632	632
query65	4893	4795	4822	4795
query66	1714	456	333	333
query67	29702	29805	29607	29607
query68	2992	1683	1001	1001
query69	413	299	260	260
query70	1062	982	947	947
query71	277	230	221	221
query72	2881	2572	2346	2346
query73	828	796	442	442
query74	5135	4975	4787	4787
query75	2624	2593	2221	2221
query76	2326	1170	742	742
query77	349	371	283	283
query78	12452	12506	12025	12025
query79	1578	1158	776	776
query80	1267	466	382	382
query81	525	282	239	239
query82	596	161	121	121
query83	310	269	242	242
query84	257	145	113	113
query85	896	510	410	410
query86	440	300	293	293
query87	3374	3348	3167	3167
query88	3691	2793	2784	2784
query89	423	373	336	336
query90	1881	181	173	173
query91	170	162	161	161
query92	63	62	57	57
query93	1657	1485	960	960
query94	712	346	302	302
query95	681	376	340	340
query96	1042	783	345	345
query97	2708	2705	2541	2541
query98	213	205	201	201
query99	1172	1164	1037	1037
Total cold run time: 262412 ms
Total hot run time: 177416 ms

@hello-stephen

hello-stephen commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 83f03d5d0529d859d941430873ea89a60dbab7d3, data reload: false

query1	0.01	0.00	0.01
query2	0.11	0.05	0.04
query3	0.26	0.14	0.14
query4	1.61	0.14	0.14
query5	0.25	0.23	0.23
query6	1.24	1.06	1.06
query7	0.03	0.01	0.00
query8	0.10	0.04	0.03
query9	0.38	0.33	0.32
query10	0.61	0.56	0.56
query11	0.20	0.15	0.13
query12	0.19	0.15	0.14
query13	0.49	0.49	0.49
query14	1.01	1.00	1.02
query15	0.62	0.60	0.61
query16	0.33	0.33	0.32
query17	1.15	1.14	1.11
query18	0.23	0.21	0.22
query19	2.02	1.94	1.97
query20	0.02	0.01	0.02
query21	15.43	0.22	0.13
query22	4.70	0.05	0.05
query23	16.12	0.33	0.12
query24	3.00	0.44	0.32
query25	0.11	0.05	0.04
query26	0.73	0.20	0.16
query27	0.05	0.04	0.04
query28	3.56	0.96	0.56
query29	12.53	4.33	3.50
query30	0.27	0.16	0.15
query31	2.77	0.63	0.31
query32	3.23	0.60	0.48
query33	3.20	3.18	3.17
query34	15.50	4.22	3.52
query35	3.58	3.54	3.56
query36	0.55	0.46	0.40
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.04
query40	0.19	0.16	0.16
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.72 s
Total hot run time: 25.34 s

@hello-stephen

hello-stephen commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 54.38% (21312/39191)
Line Coverage 38.02% (203686/535748)
Region Coverage 34.04% (159932/469834)
Branch Coverage 35.02% (69903/199629)

@hello-stephen

hello-stephen commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.10% (28356/38266)
Line Coverage 58.05% (309189/532597)
Region Coverage 54.87% (258991/471978)
Branch Coverage 56.22% (112366/199884)

@heguanhui

heguanhui commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

run nonConcurrent

@heguanhui heguanhui force-pushed the fix/tsan-get-cell-link-error branch from 83f03d5 to f96d3cb Compare June 17, 2026 17:15
@heguanhui

heguanhui commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28854 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f96d3cb945fefbaf4af1565ad2471c611cbb766f, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17686	4058	4066	4058
q2	2001	305	201	201
q3	10313	1408	827	827
q4	4680	466	339	339
q5	7480	846	569	569
q6	179	176	145	145
q7	787	833	630	630
q8	9678	1599	1516	1516
q9	6344	4476	4480	4476
q10	6829	1787	1507	1507
q11	446	274	242	242
q12	667	407	305	305
q13	18156	3371	2727	2727
q14	272	256	252	252
q15	q16	784	775	709	709
q17	992	885	975	885
q18	6730	5826	5477	5477
q19	1311	1294	1125	1125
q20	527	403	262	262
q21	5918	2588	2301	2301
q22	442	360	301	301
Total cold run time: 102222 ms
Total hot run time: 28854 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4465	4350	4391	4350
q2	332	363	230	230
q3	4605	4921	4402	4402
q4	2033	2149	1359	1359
q5	4449	4333	4311	4311
q6	234	180	125	125
q7	1715	1663	1904	1663
q8	2576	2189	2101	2101
q9	7944	8090	7987	7987
q10	4808	4792	4367	4367
q11	573	428	369	369
q12	749	755	592	592
q13	3326	3597	3031	3031
q14	299	317	295	295
q15	q16	756	753	657	657
q17	1406	1346	1337	1337
q18	7922	7375	6944	6944
q19	1085	1088	1092	1088
q20	2213	2225	1937	1937
q21	5229	4538	4386	4386
q22	512	462	427	427
Total cold run time: 57231 ms
Total hot run time: 51958 ms

@hello-stephen

hello-stephen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 175285 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f96d3cb945fefbaf4af1565ad2471c611cbb766f, data reload: false

query5	4325	623	491	491
query6	451	195	169	169
query7	4938	527	316	316
query8	354	213	195	195
query9	8763	4024	4070	4024
query10	425	308	258	258
query11	5918	2330	2116	2116
query12	150	99	96	96
query13	1285	612	438	438
query14	6347	5394	5063	5063
query14_1	4402	4384	4417	4384
query15	202	206	184	184
query16	997	477	434	434
query17	1152	684	542	542
query18	2534	464	344	344
query19	189	196	135	135
query20	112	104	105	104
query21	214	137	119	119
query22	13625	13643	13502	13502
query23	17276	16556	16162	16162
query23_1	16217	16314	16267	16267
query24	7529	1733	1299	1299
query24_1	1325	1317	1326	1317
query25	526	430	355	355
query26	1307	324	166	166
query27	2674	559	334	334
query28	4450	2032	2045	2032
query29	1044	610	466	466
query30	311	237	195	195
query31	1108	1081	958	958
query32	101	62	57	57
query33	502	298	239	239
query34	1183	1194	651	651
query35	730	766	675	675
query36	1379	1391	1208	1208
query37	152	106	90	90
query38	3195	3113	3042	3042
query39	936	914	884	884
query39_1	866	881	884	881
query40	212	122	97	97
query41	62	61	62	61
query42	92	93	88	88
query43	322	331	279	279
query44	1405	777	793	777
query45	193	186	178	178
query46	1063	1226	759	759
query47	2325	2374	2266	2266
query48	409	429	296	296
query49	645	473	361	361
query50	988	359	267	267
query51	4356	4332	4384	4332
query52	88	89	78	78
query53	253	271	204	204
query54	301	261	217	217
query55	80	79	72	72
query56	239	232	220	220
query57	1432	1447	1313	1313
query58	239	223	226	223
query59	1550	1642	1468	1468
query60	281	256	232	232
query61	175	170	178	170
query62	690	654	597	597
query63	235	195	196	195
query64	2570	793	644	644
query65	4815	4788	4769	4769
query66	1813	459	336	336
query67	29732	29699	29540	29540
query68	3063	1583	923	923
query69	416	304	265	265
query70	1073	963	975	963
query71	294	229	214	214
query72	2841	2591	2365	2365
query73	851	832	430	430
query74	5070	4966	4804	4804
query75	2654	2590	2229	2229
query76	2305	1161	769	769
query77	353	378	277	277
query78	12283	12478	11788	11788
query79	1495	1140	782	782
query80	1286	513	378	378
query81	525	280	237	237
query82	599	156	122	122
query83	319	268	245	245
query84	273	148	115	115
query85	888	503	401	401
query86	421	284	284	284
query87	3357	3281	3154	3154
query88	3675	2774	2738	2738
query89	421	382	337	337
query90	1891	187	187	187
query91	171	162	131	131
query92	62	58	57	57
query93	1568	1507	924	924
query94	690	316	306	306
query95	665	374	437	374
query96	1060	797	350	350
query97	2684	2708	2557	2557
query98	210	222	195	195
query99	1167	1163	1037	1037
Total cold run time: 260460 ms
Total hot run time: 175285 ms

@hello-stephen

hello-stephen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.19 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f96d3cb945fefbaf4af1565ad2471c611cbb766f, data reload: false

query1	0.00	0.00	0.00
query2	0.10	0.05	0.05
query3	0.26	0.13	0.13
query4	1.60	0.14	0.13
query5	0.24	0.22	0.24
query6	1.29	1.07	1.03
query7	0.03	0.00	0.00
query8	0.06	0.04	0.04
query9	0.36	0.30	0.32
query10	0.56	0.56	0.54
query11	0.20	0.13	0.14
query12	0.18	0.15	0.15
query13	0.46	0.46	0.47
query14	1.02	0.98	1.00
query15	0.62	0.58	0.59
query16	0.31	0.32	0.32
query17	1.06	1.13	1.10
query18	0.23	0.21	0.20
query19	2.06	1.97	2.02
query20	0.02	0.01	0.01
query21	15.44	0.21	0.13
query22	4.88	0.05	0.05
query23	16.14	0.30	0.12
query24	2.99	0.41	0.33
query25	0.10	0.05	0.05
query26	0.75	0.22	0.16
query27	0.04	0.03	0.04
query28	3.50	0.94	0.52
query29	12.50	4.34	3.48
query30	0.27	0.15	0.15
query31	2.77	0.61	0.31
query32	3.22	0.58	0.48
query33	3.24	3.23	3.30
query34	15.53	4.19	3.51
query35	3.51	3.52	3.56
query36	0.53	0.45	0.43
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.16	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.04
Total cold run time: 96.58 s
Total hot run time: 25.19 s

@hello-stephen

hello-stephen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.04% (28334/38267)
Line Coverage 58.02% (309025/532621)
Region Coverage 54.80% (258645/471983)
Branch Coverage 56.20% (112345/199893)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luwei16 luwei16 Awaiting requested review from luwei16

@liaoxin01 liaoxin01 Awaiting requested review from liaoxin01 liaoxin01 is a code owner

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@morningman morningman Awaiting requested review from morningman morningman is a code owner

@Gabriel39 Gabriel39 Awaiting requested review from Gabriel39 Gabriel39 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] TSAN build fails with undefined symbol: BlockFileCache::get_cell<std::lock_guard<std::mutex>>

2 participants

@heguanhui @hello-stephen