[fix](cases) remove duplicate cases and useless out check file#64687
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
Reviewed PR 64687.
I did not find a substantiated blocking issue.
Critical checkpoint conclusions:
- Goal/test intent: This removes a duplicated
SHOW CREATE TABLEregression smoke suite and its stale output file. The remainingtest_show_create_table.groovystill exercises the same two table definitions andSHOW CREATE TABLEcalls. - Scope: The change is narrow and limited to deleting the duplicate suite/output.
- Concurrency/lifecycle/config/compatibility: Not applicable; no runtime code, config, protocol, storage format, transaction, or lifecycle path changes.
- Parallel paths: I checked the apparent Nereids-specific path.
checkNereidsExecutecurrently delegates tosql(...), and separateSHOW CREATE TABLENereids coverage remains inshow_p0/test_show_create_table_and_views_nereids.groovy. - Tests/results: The deleted
.outbelongs to a suite that uses plainsqlassertions, notqt_/order_qt_output comparison; removing it is consistent with the framework. I did not run the regression suite locally in this review runner. - Observability/performance: Not applicable for this test deletion.
User focus: no additional user-provided focus was supplied.
Subagent conclusions: optimizer-rewrite found no optimizer/rewrite candidate because no planner/rewrite source path changes and the relevant command path is metadata-only. tests-session-config found no tests/session/config candidate after comparing the deleted suite to the retained suite, checking checkNereidsExecute, stale references, title-check regex compatibility, and git diff --check. Convergence round 1 ended with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the same current ledger/comment set.
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Problem Summary:
test_show_create_table_nereids duplicate with test_show_create_table
test_show_create_table's outfile is useless
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)