Skip to content

[fix](cases) remove duplicate cases and useless out check file#64687

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:remove-dup-case
Jun 23, 2026
Merged

[fix](cases) remove duplicate cases and useless out check file#64687
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:remove-dup-case

Conversation

@morrySnow

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:

test_show_create_table_nereids duplicate with test_show_create_table
test_show_create_table's outfile is useless

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow

Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR 64687.

I did not find a substantiated blocking issue.

Critical checkpoint conclusions:

  • Goal/test intent: This removes a duplicated SHOW CREATE TABLE regression smoke suite and its stale output file. The remaining test_show_create_table.groovy still exercises the same two table definitions and SHOW CREATE TABLE calls.
  • Scope: The change is narrow and limited to deleting the duplicate suite/output.
  • Concurrency/lifecycle/config/compatibility: Not applicable; no runtime code, config, protocol, storage format, transaction, or lifecycle path changes.
  • Parallel paths: I checked the apparent Nereids-specific path. checkNereidsExecute currently delegates to sql(...), and separate SHOW CREATE TABLE Nereids coverage remains in show_p0/test_show_create_table_and_views_nereids.groovy.
  • Tests/results: The deleted .out belongs to a suite that uses plain sql assertions, not qt_/order_qt_ output comparison; removing it is consistent with the framework. I did not run the regression suite locally in this review runner.
  • Observability/performance: Not applicable for this test deletion.

User focus: no additional user-provided focus was supplied.

Subagent conclusions: optimizer-rewrite found no optimizer/rewrite candidate because no planner/rewrite source path changes and the relevant command path is metadata-only. tests-session-config found no tests/session/config candidate after comparing the deleted suite to the retained suite, checking checkNereidsExecute, stale references, title-check regex compatibility, and git diff --check. Convergence round 1 ended with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the same current ledger/comment set.

@morrySnow morrySnow merged commit f3216d8 into apache:master Jun 23, 2026
35 checks passed
@morrySnow morrySnow deleted the remove-dup-case branch June 23, 2026 02:26
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants