Tweak callback API#612
Merged
Merged
Conversation
* Rename the 'fit_callback' parameter on the '.fit' method to just 'callback' (since the fit_ is redundant) * Update fit method signatures of subclasses like the ANN models and ItemItem models to be consistent with the base class * fix issue in implicit/cpu/als.py where the callback parameter wasn't being used, and add a unittest that tests this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'callback' (since the fit_ is redundant)
be consistent with the base class
a unittest that tests this