This repository was archived by the owner on Jul 16, 2020. It is now read-only.
ciao-launcher: Use MiB in the launcher storage code#1018
Merged
Conversation
e9362fb to
505d644
Compare
This makes us more consistent with the rest of ciao and general industry expectations. Fixes: ciao-project#990 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
505d644 to
6b01622
Compare
Contributor
Author
|
@markdryan to review |
|
Lgtm, but awaiting Mark |
Contributor
|
The launcher changes look good but should we also change the names of payloads.Ready.DiskTotalMB and payloads.Stat.DiskTotalMB? Should we also change the text in the WebUI from MB to MiB? |
Contributor
Author
|
@markdryan Will do - but i'll put those into a separate PR as they're quite widespread and should really change the database schemas. |
Contributor
|
@rbradford Sounds good to me. |
markdryan
approved these changes
Jan 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes us more consistent with the rest of ciao and general industry
expectations.
Fixes: #990
Signed-off-by: Rob Bradford robert.bradford@intel.com