This repository was archived by the owner on Jul 16, 2020. It is now read-only.
Fix #1027 - workload yaml parsing#1028
Merged
Merged
Conversation
As the yaml tags were missing on the source struct the source type for the source was not being correctly parsed from the yaml file. Fixes: ciao-project#1027 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Rather that rely on the implicit creation of a storage resource derived from the image_id update the examples to make it explicit how to specify an image source. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the parsing of workload storage specified in the .yaml file. When then transition from yaml to json happened the disks struct was omitted resulting the yaml files being incorrectly parsed.
This PR fixes the tags on the struct and updates the examples to explicitly use the source type.
A further PR will remove the image_id functionality as per #988