This repository was archived by the owner on Jul 16, 2020. It is now read-only.
small fixes#1129
Merged
Merged
Conversation
added 3 commits
February 8, 2017 08:49
A copy/paste mistake made for a status variable being called an error variable. Make it status for readability Signed-off-by: Tim Pepper <timothy.c.pepper@linux.intel.com>
I noticed a little ghost and decided to s/bookeeping/bookkeeping ;) Signed-off-by: Tim Pepper <timothy.c.pepper@linux.intel.com>
The channel timeout tests are leaving command/error/event/status results on the test channels. They need to each clean up after themselves, otherwise the channel is pre-seeded with an event which can cause another test to incorrectly proceed instead of waiting synchronously for a result. As the proverb says: Channels orchestrate; mutexes serialize. We're hoping for a certain amount of serialization and aren't getting it because the orchestration is faulty when it leaves unhandled messages on the channel. Signed-off-by: Tim Pepper <timothy.c.pepper@linux.intel.com>
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cobbles together a few small fixes based on code inspection: a misnamed variable which is less clear than it should be, a simple comment typo, and a bug in normally-not-run (due to "-short") testutil results channel timeout unit tests.