This repository was archived by the owner on Jul 16, 2020. It is now read-only.
Minor datastore/database cleanups#983
Merged
Merged
Conversation
When the database code was pulled out from the datastore some functions didn't have their DB suffixes removed. This change renames those functions. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Use the same variable names for the temporary variables as will be used for the struct member. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Rename some create and remove prefixes to add and delete to give some consistency across the persistent store API. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
This served no purpose in the current abstraction as all DB actions do not cache their result. The caching occurs at the datastore layer. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
markdryan
approved these changes
Jan 4, 2017
markdryan
left a comment
Contributor
There was a problem hiding this comment.
Looks okay to me and passes BAT.
Contributor
|
@kaccardi Is this one okay for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #921 I mention a few areas where the database code can be tidied-up from my previous digs into that code. This PR addresses some of the easiest changes via automated renames.