transport: use reverse lookup to match wildcard DNS SAN#8281
Merged
Conversation
gyuho
reviewed
Jul 19, 2017
| if err != nil { | ||
| errStr = " (" + err.Error() + ")" | ||
| } | ||
| return fmt.Errorf("tls: %q does not match any of DNSNames %q"+errStr, h, cert.DNSNames) |
Author
There was a problem hiding this comment.
already gets the space from " ("
Codecov Report
@@ Coverage Diff @@
## master #8281 +/- ##
==========================================
- Coverage 76.42% 76.21% -0.22%
==========================================
Files 346 346
Lines 27055 27079 +24
==========================================
- Hits 20676 20637 -39
- Misses 4901 4963 +62
- Partials 1478 1479 +1
Continue to review full report at Codecov.
|
added 2 commits
July 21, 2017 16:43
Author
|
This didn't work as approved; PTR records will return a trailing '.' that has to be stripped off. I've also added wildcard certs / a container for testing DNS. /cc @gyuho |
|
Can we have a 3.2.5 release? Waiting on this PR to re-enable peer authentication on my clusters. |
Contributor
|
We will release this Wednesday or Friday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8268