Implement serialization for IndexIVFFlatPanorama#4636
Closed
aknayar wants to merge 2 commits into
Closed
Conversation
aknayar
commented
Oct 24, 2025
| WRITE1(ailp->nlist); | ||
| WRITE1(ailp->code_size); | ||
| WRITE1(ailp->n_levels); | ||
| uint32_t list_type = fourcc("full"); |
Contributor
Author
There was a problem hiding this comment.
I notice that the implementation for ArrayInvertedLists potentially writes a sparse buffer. However, I'm pretty sure that case is incredibly unlikely, and thus didn't implement it here. That being said, if others think it's worthwhile to implement that case, I will.
aknayar
commented
Oct 24, 2025
| xt, xb, xq = self.generate_data(d, nt, nb, nq, seed=2024) | ||
|
|
||
| # Create and populate Panorama indexes | ||
| indexes = [self.create_panorama(d, nlist, nlevels, xt, xb, nprobe=32)] |
Contributor
Author
There was a problem hiding this comment.
Maintained as a list to prepare for other incoming Panorama indexes (e.g. IndexHNSWFlatPanorama #4621).
Contributor
|
@mnorris11 has imported this pull request. If you are a Meta employee, you can view this in D85450597. |
Contributor
|
@mnorris11 merged this pull request in 859127c. |
dimitraseferiadi
pushed a commit
to dimitraseferiadi/SuCo_CSPG_SHG
that referenced
this pull request
Mar 8, 2026
…4636) Summary: ## Changes This PR implements `write_index` and `read_index` for `IndexIVFFlatPanorama`. ## Testing Added a test to `test_panorama` to verify integrity of `search()` results after writing and reading back the index from disk. Pull Request resolved: facebookresearch#4636 Reviewed By: subhadeepkaran Differential Revision: D85450597 Pulled By: mnorris11 fbshipit-source-id: 19e065f223b60f8abe14bb0bb8f67f2c8f339234
dimitraseferiadi
pushed a commit
to dimitraseferiadi/SuCo_CSPG_SHG
that referenced
this pull request
Mar 16, 2026
…4636) Summary: ## Changes This PR implements `write_index` and `read_index` for `IndexIVFFlatPanorama`. ## Testing Added a test to `test_panorama` to verify integrity of `search()` results after writing and reading back the index from disk. Pull Request resolved: facebookresearch#4636 Reviewed By: subhadeepkaran Differential Revision: D85450597 Pulled By: mnorris11 fbshipit-source-id: 19e065f223b60f8abe14bb0bb8f67f2c8f339234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements
write_indexandread_indexforIndexIVFFlatPanorama.Testing
Added a test to
test_panoramato verify integrity ofsearch()results after writing and reading back the index from disk.