Different approach to require to avoid webpack bundling#10
Merged
Conversation
Owner
Author
|
/cc @hdgarrood not sure if you'll get the ping above because I misspelled your name yet again before editing the correct speeelng in. |
Contributor
|
I don't even know the difference. I just used |
Owner
Author
|
Ok, thanks for testing! This should be fine then I think. |
Owner
Author
|
@jplatte There's nothing wrong with |
|
Looks sensible enough to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually resolve #6 at last. Going via
module.requireworked in Affjax, so I've taken the same approach here.@hdgarrood @jplatte do you know if there's a reason why we can't use
module.requireinstead ofrequire? Going viamoduleshould still work in node 6, should it not?