Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Format generated files with goimports#458

Merged
cvgw merged 1 commit into
golang:masterfrom
timebertt:feature/goimports
Jul 31, 2020
Merged

Format generated files with goimports#458
cvgw merged 1 commit into
golang:masterfrom
timebertt:feature/goimports

Conversation

@timebertt

@timebertt timebertt commented Jul 16, 2020

Copy link
Copy Markdown
Contributor

Fixes #393

Description
This PR changes mockgen to generate files that are goimports-formatted.

The actual change is in mockgen/mockgen.go, the other changes are generated.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Reviewer Notes

  • The code flow looks good.
  • Tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Format generated files with goimports

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@timebertt

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@timebertt

Copy link
Copy Markdown
Contributor Author

cc @codyoss
Can you take a look, please?

@timebertt

Copy link
Copy Markdown
Contributor Author

Ping
Can somebody check the PR, please?

@cvgw cvgw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why are imports not formatted with goimports?

3 participants