Replace manual mock generation with go generate#22
Merged
Conversation
Member
Author
|
@disiqueira — would you be open to reviewing another PR? |
b89abb0 to
4056044
Compare
This uses the builtin Go method for generating mocks; read more in: https://blog.codecentric.de/en/2017/08/gomock-tutorial/#using-gomock-with-gogenerate As a result, we can clean up quite a bit of code and manual workarounds, and the generated code is identical (minus the copyright header); that said, this feature was added on 25 Dec 2018 in golang/mock#234 which was after the most-recent release of v1.2.0 on 8 Dec 2018, so it's not available to us just yet.
4056044 to
966a7c2
Compare
d6o
approved these changes
Apr 10, 2019
Contributor
|
👍 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the builtin Go method for generating mocks; read more in:
https://blog.codecentric.de/en/2017/08/gomock-tutorial/#using-gomock-with-gogenerate
As a result, we can clean up quite a bit of code and manual workarounds,
and the generated code is identical (minus the copyright header); that
said, this feature was added on 25 Dec 2018 in
golang/mock#234 which was after the most-recent
release of v1.2.0 on 8 Dec 2018, so it's not available to us just yet.