Skip to content

Add dependency for resource proto. #7585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Mar 27, 2019
Merged

Add dependency for resource proto. #7585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions bigquery_storage/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
release_status = 'Development Status :: 3 - Alpha'
dependencies = [
'google-api-core[grpc] >= 1.6.0, < 2.0.0dev',
'googleapis-common-protos >= 1.5.9, < 2.0.0dev',
'enum34; python_version < "3.4"',
]
extras = {
Expand Down
6 changes: 3 additions & 3 deletions bigquery_storage/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"updateTime": "2019-03-25T21:54:47.957767Z",
"updateTime": "2019-03-27T17:44:10.575389Z",
"sources": [
{
"generator": {
Expand All @@ -12,8 +12,8 @@
"git": {
"name": "googleapis",
"remote": "git@github.com:googleapis/googleapis.git",
"sha": "e80435a132c53da26f46daf0787035ee63fb942b",
"internalRef": "239938670"
"sha": "d4d57d766601105478c661132f2687e6984b92d5",
"internalRef": "240469931"
}
}
],
Expand Down
14 changes: 0 additions & 14 deletions bigquery_storage/synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,6 @@
],
)

# START: Remove unnecessary dependency on google.api.resource protos.
s.replace(
["google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py"],
"from google.api import resource_pb2 as google_dot_api_dot_resource__pb2\n",
"",
)

s.replace(
["google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py"],
"google_dot_api_dot_resource__pb2.DESCRIPTOR,",
"",
)
# END: Remove unnecessary dependency on google.api.resource protos.

s.replace(
[
"google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py",
Expand Down