aiter-flash-attn: rename public sink param to s_aux#992
Closed
Abdennacer-Badaoui wants to merge 1 commit into
Closed
aiter-flash-attn: rename public sink param to s_aux#992Abdennacer-Badaoui wants to merge 1 commit into
Abdennacer-Badaoui wants to merge 1 commit into
Conversation
…mers FA convention
We will go with a different approach where we allow different namings for the same parameter
Member
Author
|
No need for this. We will allow multiple different names for the same argument here : huggingface/transformers#45153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformers' FA introspection only recognizes
s_aux(vllm-fa3) orlearnable_sink(FA4) as the sink-param name. Our public arg wassink, so transformers silently dropped the sink tensor on the way to the kernel and attention ran without sinks (visible as degenerate repetitive output on gpt-oss). Renaming the public param tos_aux(internal kernel path unchanged) fixes the wire-up.